Skip to content

feat(a11y): use list-style-stype instead of list-style none to avoid losing semantic role in Safari #41651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MaxLardenois
Copy link
Contributor

Description

Replace list-style: none by list-style-type: ""

Motivation & Context

In Safari, using list-style: none will remove its semantic role of list, therefore it will not be announced by screen readers as such. One solution is to add role: list on each affected lists but that means relying on a good usage and adds unnecessary code. Another solution as explained here is to use list-style-type: "" instead, this will have the same visual effect but won't remove semantic role.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@mdo
Copy link
Member

mdo commented Aug 8, 2025

@patrickhlauke Would you mind taking a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants