Skip to content

Conversation

@coliff
Copy link
Contributor

@coliff coliff commented Apr 24, 2025

Description

No need to define description, title and image twitter cards since it'll use Open Graph ones anyway (which are identical).

For reference see bottom section at: https://developer.x.com/en/docs/x-for-websites/cards/guides/getting-started#twitter-cards-and-open-graph

Motivation & Context

Removing this will save some bytes on every page. :-)

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

No need to define description, title and image since it'll use OpenGraph ones anyway (which are identical). Removing this will save some bytes. :-)

See bottom section at: https://developer.x.com/en/docs/x-for-websites/cards/guides/getting-started#twitter-cards-and-open-graph
@julien-deramond julien-deramond self-requested a review April 24, 2025 12:57
@github-project-automation github-project-automation bot moved this to To do in v5.3.6 Apr 24, 2025
@julien-deramond julien-deramond moved this from To do to Review in progress in v5.3.6 Apr 24, 2025
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch—thanks for the PR, @coliff! You're right, these aren't needed. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants