Skip to content

buttons plugin : avoid multiple change event trigger #31000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 2, 2020
Merged

buttons plugin : avoid multiple change event trigger #31000

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c3db204
avoid multiple change event trigger :
Lausselloic Jun 10, 2020
b2033e2
Merge branch 'v4-dev' into buttons_prevent_multiple_onchange
XhmikosR Sep 16, 2020
a01b2bf
replace `avoidTriggerChange` parameter by a css class `CLASS_NAME_CHA…
Lausselloic Oct 1, 2020
543c53f
Merge branch 'v4-dev' into buttons_prevent_multiple_onchange
Lausselloic Oct 1, 2020
b2b3607
fix linting error and upgrade bundlesize
Lausselloic Oct 1, 2020
4162e58
fix latest lint error
Lausselloic Oct 1, 2020
1632d3c
Revert "replace `avoidTriggerChange` parameter by a css class `CLASS_…
Lausselloic Oct 2, 2020
8a37b3b
Update .bundlewatch.config.json
XhmikosR Oct 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions js/src/button.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ class Button {

// Public

toggle() {
toggle(avoidTriggerChange) {
let triggerChangeEvent = true
let addAriaPressed = true
const rootElement = $(this._element).closest(
Expand Down Expand Up @@ -86,7 +86,9 @@ class Button {
input.checked = !this._element.classList.contains(CLASS_NAME_ACTIVE)
}

$(input).trigger('change')
if (!avoidTriggerChange) {
$(input).trigger('change')
}
}

input.focus()
Expand All @@ -113,7 +115,7 @@ class Button {

// Static

static _jQueryInterface(config) {
static _jQueryInterface(config, avoidTriggerChange) {
return this.each(function () {
let data = $(this).data(DATA_KEY)

Expand All @@ -123,7 +125,7 @@ class Button {
}

if (config === 'toggle') {
data[config]()
data[config](avoidTriggerChange)
}
})
}
Expand Down Expand Up @@ -154,8 +156,8 @@ $(document)
return
}

if (initialButton.tagName !== 'LABEL' || inputBtn && inputBtn.type !== 'checkbox') {
Button._jQueryInterface.call($(button), 'toggle')
if (initialButton.tagName === 'INPUT' || button.tagName !== 'LABEL') {
Button._jQueryInterface.call($(button), 'toggle', initialButton.tagName === 'INPUT')
}
}
})
Expand Down
26 changes: 26 additions & 0 deletions js/tests/unit/button.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,32 @@ $(function () {
$group.find('label').trigger('click')
})

QUnit.test('should trigger label change event only once', function (assert) {
assert.expect(1)
var done = assert.async()
var countChangeEvent = 0

var groupHTML = '<div class="btn-group" data-toggle="buttons">' +
'<label class="btn btn-primary">' +
'<input type="checkbox"><span class="check">✓</span> <i class="far fa-clipboard"></i> <span class="d-none d-lg-inline">checkbox</span>' +
'</label>' +
'</div>'
var $group = $(groupHTML).appendTo('#qunit-fixture')

var $btn = $group.children().eq(0)

$group.find('label').on('change', function () {
countChangeEvent++
})

setTimeout(function () {
assert.ok(countChangeEvent === 1, 'onchange event fired only once')
done()
}, 5)

$btn[0].click()
})

QUnit.test('should check for closest matching toggle', function (assert) {
assert.expect(18)
var groupHTML = '<div class="btn-group" data-toggle="buttons">' +
Expand Down