Fixed Navbar documentation #30912
Closed
Fixed Navbar documentation #30912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@XhmikosR Requesting review . |
Member
|
You don't need to ping us, someone will have a look when they have time, thanks. |
Member
|
@psjishnu Can you clean up the commits here? There are several unrelated ones in the history. |
Member
|
@mdo it doesn't matter if you squash and merge :) |
Author
|
Please ping me if there is need of any changes |
Member
|
I haven't checked if there any other cases @mdo, but if it looks good, I"ll backport it to v4-dev too. |
Contributor
|
It has been covered in #30973 though. |
Member
|
Closing for #30973. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #30880: .nav-item is not required on .nav-link inside .navbar-nav