Skip to content

Conversation

@mdo
Copy link
Member

@mdo mdo commented May 13, 2020

Consolidates some CSS and beefs up the selector to account for inherited border styles. Fixes #30793, a regression from v4.4.1 that shipped in #30497.

@mdo mdo requested a review from a team as a code owner May 13, 2020 22:16
@XhmikosR
Copy link
Member

Adding the comment from the issue so that we triple check before merging #30793 (comment)

Consolidates some CSS and beefs up the selector to account for inherited border styles. Fixes #30793, a regression from v4.4.1 that shipped in #30497.
@mdo mdo force-pushed the card-list-group-borders branch from cfc230d to 9807b5a Compare May 14, 2020 15:53
Copy link
Member

@MartijnCuppens MartijnCuppens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proper solution 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

This fix brokes border between card-header and list-group, it's doubled in 4.5.0.

4 participants