-
-
Notifications
You must be signed in to change notification settings - Fork 79.2k
v4/v5: Add responsive containers #29095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
a40f882
create responsive containers
browner12 146e269
fix the base container code
browner12 45baca9
formatting for style
browner12 c54fb6c
finish incomplete comment
browner12 b168eaa
fix the responsive containers
browner12 47c79a3
fix responsive containers in the navbar
browner12 372c361
Merge branch 'v4-dev' into responsive-containers
browner12 03d05e1
Merge branch 'v4-dev' into responsive-containers
XhmikosR da8e161
Merge branch 'v4-dev' into responsive-containers
XhmikosR d811a83
Merge branch 'v4-dev' into responsive-containers
XhmikosR 88b5f26
Merge branch 'v4-dev' into responsive-containers
XhmikosR 6adba35
Simplify container extends
MartijnCuppens ae5c9c5
Simplify navbar containers
MartijnCuppens 436a2e2
Merge branch 'v4-dev' into responsive-containers
XhmikosR adf3174
Merge branch 'master' into responsive-containers
XhmikosR 6032ac7
Rearrange, add comments, ensure everything is nested in $enable-grid-…
mdo eaf5b18
Reduce new CSS by using attribute selector
mdo f7e486d
Update _grid.scss
mdo 464bf78
Update _navbar.scss
mdo bb3a2e3
Merge branch 'responsive-containers' of https://github.com/browner12/…
mdo edec07f
Add docs for responsive containers, redesign the container layout page
mdo 8510cf9
Add to the Grid example
mdo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,8 +25,7 @@ | |
|
|
||
| // Because flex properties aren't inherited, we need to redeclare these first | ||
| // few properties so that content nested within behave properly. | ||
| > .container, | ||
| > .container-fluid { | ||
| > [class^="container"] { | ||
| display: flex; | ||
| flex-wrap: wrap; | ||
| align-items: center; | ||
|
|
@@ -140,8 +139,7 @@ | |
|
|
||
| &#{$infix} { | ||
| @include media-breakpoint-down($breakpoint) { | ||
| > .container, | ||
| > .container-fluid { | ||
| > [class^=".container"] { | ||
| padding-right: 0; | ||
| padding-left: 0; | ||
| } | ||
|
|
@@ -165,8 +163,7 @@ | |
| } | ||
|
|
||
| // For nesting containers, have to redeclare for alignment purposes | ||
| > .container, | ||
| > .container-fluid { | ||
| > [class^=".container"] { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This also shouldn't have a period in the class name text it's looking for. |
||
| flex-wrap: nowrap; | ||
| } | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't have a period in the class name text it's looking for.