Skip to content

Handle nullable string cases #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handle nullable string cases #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/scala/com/tuplejump/kafka/connect/cassandra/package.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,8 @@ package object cassandra {
def convert(schema: Schema, result: Struct, col: String): AnyRef =
schema.field(col).schema match {
case x if x.`type`() == Schema.STRING_SCHEMA.`type`() =>
s"'${result.get(col).toString}'"
val fieldValue = result.get(col)
if(fieldValue != null) s"'${fieldValue.toString}'" else "null"
case x if x.name() == Timestamp.LOGICAL_NAME =>
val time = Timestamp.fromLogical(x, result.get(col).asInstanceOf[JDate])
s"$time"
Expand Down
25 changes: 25 additions & 0 deletions src/test/scala/com/tuplejump/kafka/connect/cassandra/SchemaSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,31 @@ class SchemaSpec extends AbstractFlatSpec {
query.cql should be("INSERT INTO keyspacex.tablex(available,name,age) VALUES(false,'user',15)")
}

it should "convert a struct schema with multiple fields including nullable string field" in {
val topic = "test_kfk"
val sc = sinkConfig(topic, "keyspacex", "tablex", List("available", "name", "type", "age"))

val nullableStringSchema = SchemaBuilder.string().optional().build()

val schema = SchemaBuilder.struct.name("record").version(1)
.field("available", Schema.BOOLEAN_SCHEMA)
.field("name", Schema.STRING_SCHEMA)
.field("type", nullableStringSchema)
.field("age", Schema.INT32_SCHEMA).build

val value = new Struct(schema).put("name", "user").put("available", false).put("age", 15).put("type", null)
val record = new SinkRecord("test_kfk", 1, SchemaBuilder.struct.build, "key", schema, value, 0)

schema.asColumnNames should be (sc.schema.columnNames)

sc.schema.route.topic should be (record.topic)
sc.schema is record should be (true)

sc.query.cql should be ("INSERT INTO keyspacex.tablex(available,name,type,age) VALUES(?,?,?,?)")
val query = record.as(sc.schema.namespace)
query.cql should be("INSERT INTO keyspacex.tablex(available,name,type,age) VALUES(false,'user',null,15)")
}

it should "convert cassandra column defs to a source schema" in {
val colDef = Map(
"id" -> DataType.cint(),
Expand Down