IMT-164 session timeout warning #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Needs session_timeout_data in administrate
nomadicoder
changed the title
cdoyle-temple
requested changes
Oct 30, 2025
There was a problem hiding this comment.
Needs a little more work:
- Warning_lead_time should be much lower, five minutes max
- The admin and non-admin application views shouldn't hold so much config and calculations, can some of this be moved to helpers and the controllers?
- Could we have some tests for the new functionality?
- Extracts session timeout to a concern - Applies concern to both application and admin controllers
- Tests session timeout - Tests for warning and timeout message - Tests for extend session
nomadicoder
force-pushed
the
IMT-164-Session_timeout_warning
branch
from
2033a90 to
3a37239
Compare
cdoyle-temple
approved these changes
Oct 31, 2025
nomadicoder
force-pushed
the
IMT-164-Session_timeout_warning
branch
from
132d863 to
a29502b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.