Updated thrift version. #47
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(not devDependency), meaning that a lot of test libraries ended up bloating production builds using this library
Author
|
Hmm, ok, not so easy as I hoped there. It works locally, but I'll see if I can work out what the travis issue is. |
…oc, only introduced in node 5.10. Updated the travis and package engines to start testing from v6
Author
|
The latest version of thrift used a node method Buffer.alloc, which didn't exist before v5.10 so in changing the thrift version I also had to change the target 'engines' for this library to v6 and above - also changed the travis package to match. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The older verson of thrift used by this library was using a version of thrift that had 'nodeunit' as a dependency, when it should have been a devDependency. This meant that a lot of test libraries ended up bloating production builds using this library.
I also made a few other minor changes
Ran the unit tests and linter and they all passed.