[github-actions] Add more ways to grab external ID #805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging to
|
gnalh
force-pushed
the
gabe/trunk-16815-failed-to-extract-github-actions-external-id-runnerworker
branch
from
cc3705c to
4043681
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #805 +/- ##
==========================================
- Coverage 72.53% 72.37% -0.16%
==========================================
Files 72 72
Lines 15749 15864 +115
==========================================
+ Hits 11423 11482 +59
- Misses 4326 4382 +56 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| )) | ||
| } | ||
|
|
||
| /// Validate that a directory is a runner directory by checking for _diag subdirectory |
Collaborator
There was a problem hiding this comment.
I assume this logic is all specific to github actions, should it be gated into a module so that we know that, if so?
Collaborator
Author
There was a problem hiding this comment.
This is already inside of the github-actions crate.
Collaborator
There was a problem hiding this comment.
oh, duh. Missed that entirely.
cmillar-trunk
approved these changes
Oct 29, 2025
Collaborator
Author
|
Holding off on merging until I can reproduce the error cause |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.