Skip to content

Conversation

@iutx
Copy link
Contributor

@iutx iutx commented Jan 29, 2024

Fixes # No relevant issues.

RELEASE NOTES: NONE

@github-actions
Copy link

github-actions bot commented Jan 29, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@iutx
Copy link
Contributor Author

iutx commented Jan 29, 2024

I have read the CLA Document and I hereby sign the CLA

liuzengh added a commit to trpc-group/cla-database that referenced this pull request Jan 29, 2024
Copy link
Contributor

@WineChord WineChord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5dad29f) 86.02078% compared to head (c971eac) 86.00856%.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main        #163         +/-   ##
===================================================
- Coverage   86.02078%   86.00856%   -0.01222%     
===================================================
  Files            190         190                 
  Lines          16360       16360                 
===================================================
- Hits           14073       14071          -2     
- Misses          1725        1728          +3     
+ Partials         562         561          -1     
Flag Coverage Δ
unittests 86.00856% <ø> (-0.01222%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iutx
Copy link
Contributor Author

iutx commented Jan 29, 2024

Similar fixes:

@sandyskies sandyskies merged commit c8cb302 into trpc-group:main Jan 30, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants