Skip to content

chore: use RoundUpPowerOf2() in LockFreeQueue Init() #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2023
Merged

chore: use RoundUpPowerOf2() in LockFreeQueue Init() #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 5 additions & 13 deletions trpc/util/queue/lockfree_queue.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@
#include <utility>
#include <vector>

#include "trpc/util/algorithm/power_of_two.h"

namespace trpc {

/// @brief Implementation of a thread-safe lock-free queue that supports multiple producers and multiple
Expand Down Expand Up @@ -54,21 +56,11 @@ class alignas(64) LockFreeQueue {
return RT_OK;
}

bool size_is_power_of_2 = (size >= 2) && ((size & (size - 1)) == 0);
if (!size_is_power_of_2) {
uint64_t tmp = 1;
while (tmp <= size) {
tmp <<= 1;
}

size = tmp;
}

mask_ = size - 1;
capacity_ = size;
capacity_ = RoundUpPowerOf2(size);
mask_ = capacity_ - 1;

elements_ = std::make_unique<Element[]>(capacity_);
for (size_t i = 0; i < size; ++i) {
for (size_t i = 0; i < capacity_; ++i) {
elements_[i].sequence = i;
}

Expand Down