Skip to content

BufFix: fix the problem that AsyncIO fails to correctly handle the return value when using SQ_POLL #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2024
Merged

BufFix: fix the problem that AsyncIO fails to correctly handle the return value when using SQ_POLL #132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions trpc/runtime/iomodel/async_io/async_io.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,15 +108,15 @@ trpc::Future<int32_t> AsyncIO::SubmitOne(F&& fill_sqe) {
io_uring_sqe_set_data(sqe, user_data);

int ret = io_uring_submit(ring);
if (TRPC_UNLIKELY(ret != 1)) {
if (TRPC_UNLIKELY(ret <= 0)) {
trpc::object_pool::Delete<IOURingUserData>(user_data);
if (ret < 0) {
return MakeExceptionFuture<int32_t>(AsyncIOError(ret));
}
std::string msg = "Submit success but return not one, ret:" + std::to_string(ret);
return MakeExceptionFuture<int32_t>(AsyncIOError(AsyncIOError::SUBMIT_FAIL, msg));
}
submitted_++;
submitted_ += ret;

return user_data->pr.GetFuture();
}
Expand Down