feat(net): optimize the log of synchronization failure #6381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jul 3, 2025
kuny0707
approved these changes
Jul 11, 2025
kuny0707
approved these changes
Jul 11, 2025
halibobo1205
approved these changes
Jul 14, 2025
barbatos2011
approved these changes
Jul 15, 2025
| ReflectUtils.setFieldValue(peer, "tronState", TronState.INIT); | ||
|
|
||
| try { | ||
| peer.setBlockBothHave(new BlockCapsule.BlockId(Sha256Hash.ZERO_HASH, -1)); |
There was a problem hiding this comment.
18:01:38.101 WARN [net] Peer /127.0.0.2 sync failed, reason: Num:-1,ID:ffffffffffffffff000000000000000000000000000000000000000000000000
The error message here is not very clear - I suggest making it more specific. Additionally, it would be good to check other similar areas for consistency.
There was a problem hiding this comment.
It has nothing to do with this modification. You can sort out the logs and optimize them uniformly.
lvs0075
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Optimize the log of synchronization failure, Fixes #6272 , Fixes #6279
Why are these changes required?
This PR has been tested by:
Follow up
Extra details