Skip to content

feat(net): adjust disconnect strategy in isolated scene #5956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 16, 2024
Merged

feat(net): adjust disconnect strategy in isolated scene #5956

merged 3 commits into from
Aug 16, 2024

Conversation

@317787106
Copy link
Contributor

@317787106 317787106 commented Aug 15, 2024

What does this PR do?

  • only disconnect from active peers if active peer size is larger or equal to minActiveConnections in isolated scene.

Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@lvs007 lvs007 merged commit ea7ef8e into tronprotocol:release_v4.7.6 Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@lvs007 lvs007 lvs007 approved these changes

@CodeNinjaEvan CodeNinjaEvan CodeNinjaEvan approved these changes

@fyyhtx fyyhtx fyyhtx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@317787106 @lvs007 @CodeNinjaEvan @fyyhtx