feat(api): check if scalingFactor is bigger than 0 #5746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halibobo1205
reviewed
Mar 5, 2024
| TransactionCapsule trxCap = createTransactionCapsule(trigger, | ||
| ContractType.TriggerSmartContract); | ||
| trx = triggerConstantContract(trigger, trxCap, trxExtBuilder, retBuilder); | ||
| Transaction trx = triggerConstantContract(trigger, trxCap, trxExtBuilder, retBuilder); |
Contributor
There was a problem hiding this comment.
Doesn't this need to be handled?
Contributor
Author
There was a problem hiding this comment.
This part is rollback to 4.7.3.
Contributor
There was a problem hiding this comment.
What is the reason for this part of the direct rollback ? I see the previous analysis which is also wrong
Contributor
Author
There was a problem hiding this comment.
Only this part is new added:
if (scalingFactor.compareTo(BigInteger.ZERO) <= 0) {
throw new ContractValidateException("scalingFactor must be positive");
}
Other part is still same as before. Check the condition outside this method is not only easy to understand and but also include all conditions.
Contributor
Author
There was a problem hiding this comment.
@halibobo1205 what's wrong with previous analysis? This optimization is to coverage this additional case: contract and method scalingFactor are both exist, but it really return 0.
jwrct
approved these changes
Mar 6, 2024
halibobo1205
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Why are these changes required?
This PR has been tested by:
Follow up
Extra details