feat(net): delete four unused paramaters in Args #5441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
317787106
changed the title
jwrct
reviewed
Aug 23, 2023
| //public static final String NODE_DISCOVERY_PUBLIC_HOME_NODE = "node.discovery.public.home.node"; | ||
| //public static final String NODE_DISCOVERY_PING_TIMEOUT = "node.discovery.ping.timeout"; | ||
|
|
||
| public static final String NODE_P2P_PING_INTERVAL = "node.p2p.pingInterval"; |
Contributor
There was a problem hiding this comment.
Why not delete NODE_P2P_PING_INTERVAL?
Contributor
Author
There was a problem hiding this comment.
Yes, there is something wrong when split pr. I have deleted it.
| public int minParticipationRate; | ||
| @Getter | ||
| public P2pConfig p2pConfig; | ||
| @Getter |
Contributor
There was a problem hiding this comment.
This modification has nothing to do with this PR, right?
Contributor
Author
There was a problem hiding this comment.
Yes, there is something wrong when split pr. I have deleted it.
| // public long nodeDiscoveryPingTimeout; | ||
| // @Getter | ||
| // @Setter | ||
| // public long nodeP2pPingInterval; |
Contributor
There was a problem hiding this comment.
Why is it commented out instead of just deleting the code?
Contributor
Author
There was a problem hiding this comment.
We could delete it next release version.
Contributor
There was a problem hiding this comment.
Why not just delete it?
+ 1, git ensures that changes are kept.
Contributor
Author
There was a problem hiding this comment.
ok，I will delete it
xxo1shine
approved these changes
Aug 28, 2023
jwrct
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Why are these changes required?
This PR has been tested by:
Follow up
Extra details