Skip to content

Conversation

@lxcmyf
Copy link
Contributor

@lxcmyf lxcmyf commented Aug 10, 2023

What does this PR do?
add gRPC implementation for certain interfaces, close #5379

Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@lxcmyf lxcmyf changed the title feat(api): add grpc implementation for some interfaces feat(api): add gRPC implementation for certain interfaces Aug 10, 2023
@lxcmyf lxcmyf force-pushed the feature/add_grpc_api branch from ee7f2a0 to 2bdcbe2 Compare August 10, 2023 07:35
@halibobo1205 halibobo1205 added this to the GreatVoyage-v4.7.3 milestone Aug 10, 2023
@halibobo1205
Copy link
Contributor

@lxcmyf LGTM, please add test to fix CI.

@lxcmyf lxcmyf force-pushed the feature/add_grpc_api branch 4 times, most recently from e15d211 to acd7bea Compare August 14, 2023 14:52
@lxcmyf lxcmyf force-pushed the feature/add_grpc_api branch from acd7bea to 7ef8205 Compare August 24, 2023 09:27
@lxcmyf lxcmyf force-pushed the feature/add_grpc_api branch from 7ef8205 to 0bf4bbc Compare August 24, 2023 10:30
@lxcmyf lxcmyf force-pushed the feature/add_grpc_api branch from bd8fdb4 to d535eb2 Compare August 24, 2023 10:34
@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2023

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 77.19298% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.31%. Comparing base (f9c42d6) to head (cc5488b).
⚠️ Report is 534 commits behind head on develop.

Files with missing lines Patch % Lines
...ain/java/org/tron/core/services/RpcApiService.java 66.66% 10 Missing ⚠️
.../core/services/http/GetBandwidthPricesServlet.java 50.00% 0 Missing and 1 partial ⚠️
...ron/core/services/http/GetEnergyPricesServlet.java 50.00% 0 Missing and 1 partial ⚠️
...on/core/services/http/GetMemoFeePricesServlet.java 50.00% 0 Missing and 1 partial ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #5412      +/-   ##
=============================================
+ Coverage      61.23%   61.31%   +0.07%     
- Complexity      9323     9330       +7     
=============================================
  Files            842      842              
  Lines          50147    50210      +63     
  Branches        5580     5580              
=============================================
+ Hits           30710    30784      +74     
+ Misses         17029    17021       -8     
+ Partials        2408     2405       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lxcmyf lxcmyf force-pushed the feature/add_grpc_api branch from 1b9ee8d to 74ad91a Compare August 28, 2023 06:56
@lxcmyf lxcmyf force-pushed the feature/add_grpc_api branch from 74ad91a to bd9ed62 Compare August 28, 2023 08:41
@lxcmyf lxcmyf force-pushed the feature/add_grpc_api branch 3 times, most recently from 92a9f45 to 6708a8e Compare August 31, 2023 04:19
@lxcmyf lxcmyf force-pushed the feature/add_grpc_api branch from 6708a8e to 9f05d9a Compare August 31, 2023 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic:api rpc/http related issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

There are no grpc implementation for getenergyprices and getbandwidthprices http API

6 participants