Skip to content

Conversation

@lurais
Copy link
Contributor

@lurais lurais commented Aug 3, 2023

What does this PR do?
Use all available cpu cores to validate transaction signatures.
Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2023

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.91%. Comparing base (9a65bb6) to head (a1b41c2).
⚠️ Report is 567 commits behind head on develop.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #5396      +/-   ##
=============================================
- Coverage      60.92%   60.91%   -0.01%     
  Complexity      9231     9231              
=============================================
  Files            839      839              
  Lines          50029    50029              
  Branches        5574     5574              
=============================================
- Hits           30479    30476       -3     
- Misses         17165    17167       +2     
- Partials        2385     2386       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tomatoishealthy tomatoishealthy linked an issue Aug 3, 2023 that may be closed by this pull request
@tomatoishealthy
Copy link
Contributor

tomatoishealthy commented Aug 3, 2023

Better remember to link the issue with this PR.

Correct to the right link if I'm wrong

@tomatoishealthy tomatoishealthy changed the title feat(sign): optimize validate sign param feat(sign): optimize validate sign default param Aug 3, 2023
@tomatoishealthy tomatoishealthy changed the title feat(sign): optimize validate sign default param feat(sign): optimize the default value of validate sign thread number Aug 3, 2023
@lurais
Copy link
Contributor Author

lurais commented Aug 3, 2023

that's right. @guoquanwu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve the efficiency of signature verification

4 participants