Skip to content

Conversation

@jwrct
Copy link
Contributor

@jwrct jwrct commented Mar 23, 2023

What does this PR do?
add configuration dynamic loading for node

Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@jwrct jwrct marked this pull request as ready for review March 29, 2023 09:54
@jwrct jwrct changed the title feat(config):add support for dynamically loading configuration feat(config):add configuration dynamic loading for node Mar 29, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2023

Codecov Report

Merging #5090 (e0c8ba5) into release_v4.7.2 (415dc52) will increase coverage by 0.08%.
The diff coverage is 79.48%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@                 Coverage Diff                  @@
##             release_v4.7.2    #5090      +/-   ##
====================================================
+ Coverage             54.75%   54.84%   +0.08%     
- Complexity             8256     8286      +30     
====================================================
  Files                   842      843       +1     
  Lines                 49848    49925      +77     
  Branches               5504     5512       +8     
====================================================
+ Hits                  27295    27382      +87     
+ Misses                20386    20373      -13     
- Partials               2167     2170       +3     
Impacted Files Coverage Δ
common/src/main/java/org/tron/core/Constant.java 50.00% <ø> (ø)
...ava/org/tron/common/parameter/CommonParameter.java 56.23% <60.00%> (+0.51%) ⬆️
.../src/main/java/org/tron/core/config/args/Args.java 59.58% <80.00%> (+0.18%) ⬆️
...in/java/org/tron/core/config/args/DynamicArgs.java 80.32% <80.32%> (ø)
...a/org/tron/common/application/ApplicationImpl.java 88.37% <100.00%> (+0.56%) ⬆️

... and 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants