Skip to content

Add default value of NULL for optional fields #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2024
Merged

Add default value of NULL for optional fields #10

merged 1 commit into from
Dec 12, 2024

Conversation

oswidan97
Copy link

Description

  • Optional fields that have NULL values were originaly removed from the resulting json file. This lead to failures downstream in the json to parquert conversion as the conversion inferes the schema and if it doesn't find a field it would error out
  • This PR makes sure all fields are added even if they have NULL values

Testing

All green ripple export
image

@oswidan97 oswidan97 requested a review from a team December 12, 2024 14:40
@oswidan97 oswidan97 self-assigned this Dec 12, 2024
@oswidan97 oswidan97 merged commit 9e94893 into master Dec 12, 2024
0 of 9 checks passed
@oswidan97 oswidan97 deleted the osw-add-default-field-values branch December 12, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Shaalan31 Shaalan31 Shaalan31 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@oswidan97 oswidan97

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oswidan97 @Shaalan31