[backend] Update LLVM version to https://github.com/llvm/llvm-project/commit/386af4a5c64ab75eaee2448dc38f2e34a40bfed0 #5974
Conversation
chsigg
commented
Feb 20, 2025
chsigg
commented
- build lld as well.
- amd gfx940 and gfx941 were removed.
- createConvertSCFToCFPass was renamed to createSCFToControlFlowPass.
- scf.for folder was introduced to remove duplicate variables.
- fixes wait states of gfx950 mfma ops.
chsigg
requested review from
antiagainst,
ptillet and
zhanglx13
as code owners
| Attribute removeArgAttrsAttr() { return nullptr; } | ||
| Attribute removeResAttrsAttr() { return nullptr; } | ||
| ArrayAttr getArgAttrsAttr() { return nullptr; } | ||
| ArrayAttr getResAttrsAttr() { return nullptr; } | ||
| void setArgAttrsAttr(ArrayAttr) { return; } | ||
| void setResAttrsAttr(ArrayAttr) { return; } |
There was a problem hiding this comment.
I think these aren't actually needed? I know this is to integrate llvm/llvm-project#123176 but these will already be auto-generated I believe. For example bump that also integrates that PR doesn't require such a change #5969.
There was a problem hiding this comment.
You are right. I didn't notice that ff77e98 did this the right way.
Removed.
|
@chsigg thanks for doing this and folding in the |
- amd gfx940 and gfx941 were removed. - createConvertSCFToCFPass was renamed to createSCFToControlFlowPass. - scf.for folder was introduced to remove duplicate variables.
Absolutely. |
Actually you should go ahead and merge - upstream reviewer seems MIA. I'll get it later. |
Pulls in: * llvm/llvm-project#127988 * llvm/llvm-project#127983 to expose buffer loads to lds in rocdl.
|
Hi @chsigg, we'd need to pick up some recent llvm commits that are brought in by this one so it would be nice to land this soon. Let me know if you need some hands to push this pull request forward. :) |
This commit updates to llvm/llvm-project@a66376b0dc3b with changes: * build lld as well. * AMD gfx940 and gfx941 were removed. * `createConvertSCFToCFPass` was renamed to `createSCFToControlFlowPass`. * `scf.for` folder was introduced to remove duplicate variables. This brings in fixes we needed for AMD gfx950 enablement. Closes triton-lang#5974.
