Skip to content

Move limit/topN pushdown tests to base connector test #26521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2025
Merged

Move limit/topN pushdown tests to base connector test #26521

merged 2 commits into from
Oct 30, 2025

Conversation

@chenjian2664
Copy link
Contributor

@chenjian2664 chenjian2664 commented Aug 31, 2025 •
edited
Loading

Description

Previously, there were no tests for non-JDBC connectors to verify limit and TopN pushdown.

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Aug 31, 2025
@chenjian2664 chenjian2664 marked this pull request as draft August 31, 2025 10:05
@github-actions github-actions bot added mongodb MongoDB connector cassandra Cassandra connector opensearch OpenSearch connector hudi Hudi connector iceberg Iceberg connector hive Hive connector elasticsearch Elasticsearch connector kafka Kafka connector pinot Pinot connector redis Redis connector labels Aug 31, 2025
@chenjian2664 chenjian2664 force-pushed the limit-topn-test-update branch 3 times, most recently from c22a9e3 to 91e40e8 Compare September 1, 2025 07:02
@github-actions github-actions bot added the memory Memory connector label Sep 1, 2025
@chenjian2664 chenjian2664 force-pushed the limit-topn-test-update branch 3 times, most recently from 867b1a9 to bcbe54e Compare September 1, 2025 17:51
@chenjian2664 chenjian2664 changed the title Move limit test to base connector test Move limit/topN pushdown tests to base connector test Sep 2, 2025
@chenjian2664 chenjian2664 marked this pull request as ready for review September 2, 2025 03:38
@ebyhr
Copy link
Member

ebyhr commented Sep 2, 2025

/test-with-secrets sha=bcbe54ef19fc100caed0302bab2d471442acd988

@github-actions
Copy link

github-actions bot commented Sep 2, 2025 •
edited
Loading

The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/17392797220

@ebyhr
Copy link
Member

ebyhr commented Sep 2, 2025

Could you fix BigQuery CI failure?

Error:    TestBigQueryAvroConnectorTest>BaseConnectorTest.testLimitPushdown:434 Plan does not match, expected [

- node(OutputNode)
    - node(TableScanNode)

] but found [

Output[columnNames = [name]]
│   Layout: [name:varchar]
└─ Limit[count = 30]
   │   Layout: [name:varchar]
   └─ LocalExchange[partitioning = SINGLE]
      │   Layout: [name:varchar]
      └─ RemoteExchange[type = GATHER]
         │   Layout: [name:varchar]
         └─ LimitPartial[count = 30]
            │   Layout: [name:varchar]
            └─ TableScan[table = bigquery:sep-bq-cicd.tpch.nation:TABLE columns=[name:varchar]]
                   Layout: [name:varchar]
                   name := name:varchar

@github-actions github-actions bot added the bigquery BigQuery connector label Sep 2, 2025
@chenjian2664
Copy link
Contributor Author

chenjian2664 commented Sep 2, 2025

@ebyhr could you help to take a look again?

@ebyhr
Copy link
Member

ebyhr commented Sep 2, 2025

/test-with-secrets sha=7b6415d85db63ba4eef0dd7260af5be3faf9d74f

@github-actions
Copy link

github-actions bot commented Sep 2, 2025 •
edited
Loading

The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/17418919957

@chenjian2664
Copy link
Contributor Author

chenjian2664 commented Sep 3, 2025

the ci failure Error: The action has timed out. not relates the change

@chenjian2664
Copy link
Contributor Author

chenjian2664 commented Sep 5, 2025

@ebyhr Could you please take a look again?

ebyhr
ebyhr reviewed Sep 5, 2025
View reviewed changes
@github-actions github-actions bot added the druid Druid connector label Sep 5, 2025
@chenjian2664 chenjian2664 force-pushed the limit-topn-test-update branch from 0a4fba3 to 310caff Compare September 5, 2025 05:52
@chenjian2664 chenjian2664 force-pushed the limit-topn-test-update branch 2 times, most recently from 33d9184 to 3e4a77b Compare September 6, 2025 04:20
@github-actions
Copy link

github-actions bot commented Oct 10, 2025

This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack.

@github-actions github-actions bot added the stale label Oct 10, 2025
@chenjian2664 chenjian2664 force-pushed the limit-topn-test-update branch from 95d72a0 to fc9efe7 Compare October 12, 2025 01:46
@chenjian2664 chenjian2664 mentioned this pull request Oct 12, 2025
Open
@chenjian2664
Copy link
Contributor Author

chenjian2664 commented Oct 12, 2025

@ebyhr Please help to have a look when you are available, thanks

@github-actions github-actions bot removed the stale label Oct 13, 2025
@chenjian2664 chenjian2664 requested a review from ebyhr October 29, 2025 09:49
@chenjian2664 @ebyhr
Move limit pushdown test into BaseConnectorTest
8e4890f 
Previously, there was no test to exercise limit pushdown behavior
for non-JDBC connectors, regardless of whether they declare support
for the `SUPPORTS_LIMIT_PUSHDOWN` TestingConnectorBehavior.
Aslo fix the bug in Memory connector test where the connector
supports limit pushdown.
@chenjian2664 @ebyhr
Move topN pushdown test into BaseConnectorTest
5e96fb2 
Previously, there was no test to exercise topN pushdown behavior
for non-JDBC connectors, regardless of whether they declare support
for the `SUPPORTS_TOPN_PUSHDOWN` TestingConnectorBehavior.
@ebyhr ebyhr force-pushed the limit-topn-test-update branch from fc9efe7 to 5e96fb2 Compare October 30, 2025 01:19
@ebyhr ebyhr merged commit 9d9b725 into trinodb:master Oct 30, 2025
98 checks passed
@github-actions github-actions bot added this to the 479 milestone Oct 30, 2025
@chenjian2664
Copy link
Contributor Author

chenjian2664 commented Oct 30, 2025

Thanks

@chenjian2664 chenjian2664 deleted the limit-topn-test-update branch October 30, 2025 06:07
@chenjian2664 chenjian2664 mentioned this pull request Oct 31, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ebyhr ebyhr ebyhr approved these changes

@Praveen2112 Praveen2112 Awaiting requested review from Praveen2112

@hashhar hashhar Awaiting requested review from hashhar

@wendigo wendigo Awaiting requested review from wendigo

Assignees

No one assigned

Labels

bigquery BigQuery connector cassandra Cassandra connector cla-signed druid Druid connector elasticsearch Elasticsearch connector hive Hive connector hudi Hudi connector iceberg Iceberg connector kafka Kafka connector lakehouse memory Memory connector mongodb MongoDB connector opensearch OpenSearch connector pinot Pinot connector redis Redis connector

Milestone

479

Development

Successfully merging this pull request may close these issues.

2 participants

@chenjian2664 @ebyhr