Skip to content

feat : Errors thrown in onStart should fail the run with that error #1640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

feat : Errors thrown in onStart should fail the run with that error #1640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9810645
feat : Errors thrown in onStart should fail the run with that error
Pratik-Mahajan257 Jan 26, 2025
a3fc6dc
fixes
Pratik-Mahajan257 Jan 26, 2025
7f67ffd
Merge branch 'main' into TRI-4372
Pratik-Mahajan257 Feb 1, 2025
0036567
Merge branch 'main' into TRI-4372
Pratik-Mahajan257 Feb 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion references/bun-catalog/trigger.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { defineConfig } from "@trigger.dev/sdk/v3";
import { logger } from "../../packages/core/dist/commonjs/v3/logger-api.js";

export default defineConfig({
runtime: "bun",
Expand All @@ -18,7 +19,12 @@ export default defineConfig({
enableConsoleLogging: false,
logLevel: "info",
onStart: async (payload, { ctx }) => {
console.log(`Task ${ctx.task.id} started ${ctx.run.id}`);
try {
console.log(`Task ${ctx.task.id} started ${ctx.run.id}`);
} catch (error) {
console.log(error)
throw error; // Re-throw to fail the run
}
},
onFailure: async (payload, error, { ctx }) => {
console.log(`Task ${ctx.task.id} failed ${ctx.run.id}`);
Expand Down
11 changes: 10 additions & 1 deletion references/v3-catalog/trigger.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,16 @@ export default defineConfig({
enableConsoleLogging: false,
logLevel: "info",
onStart: async (payload, { ctx }) => {
console.log(`Task ${ctx.task.id} started ${ctx.run.id}`);
try {
console.log(`Task ${ctx.task.id} started ${ctx.run.id}`);
} catch (error) {
console.log(
`Task ${ctx.task.id} failed ${ctx.run.id}: ${
error instanceof Error ? error.message : String(error)
}`
);
throw error; // Re-throw to fail the run
}
},
onFailure: async (payload, error, { ctx }) => {
console.log(
Expand Down