Skip to content

Increase maximum retry count for deploy run controller #1450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Increase maximum retry count for deploy run controller #1450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5ca8ad
increase max retries for all deploy run controller operations
nicktrn Nov 1, 2024
1b023f6
add changeset
nicktrn Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/poor-parrots-attend.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"trigger.dev": patch
---

Increase max retry count for deploy run controller operations
4 changes: 2 additions & 2 deletions packages/cli-v3/src/entryPoints/deploy-run-controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ const SHORT_HASH = env.TRIGGER_CONTENT_HASH!.slice(0, 9);
const logger = new SimpleLogger(`[${MACHINE_NAME}][${SHORT_HASH}]`);

const defaultBackoff = new ExponentialBackoff("FullJitter", {
maxRetries: 5,
maxRetries: 7,
});

cliLogger.loggerLevel = "debug";
Expand Down Expand Up @@ -418,7 +418,7 @@ class ProdWorker {

// Retry if we don't receive EXECUTE_TASK_RUN_LAZY_ATTEMPT in a reasonable time
// ..but we also have to be fast to avoid failing the task due to missing heartbeat
for await (const { delay, retry } of defaultBackoff.min(10).maxRetries(3)) {
for await (const { delay, retry } of defaultBackoff.min(10).maxRetries(7)) {
if (retry > 0) {
logger.log("retrying ready for lazy attempt", { retry });
}
Expand Down