Figure out how to handle Anchor 0.31

[smoelius]

anchor-coverage currently does not work with Anchor 0.31 because of changes to anchor's cli: solana-foundation/anchor#3643

[smoelius]

I think the proc-macro2 change is forcing us to move to 0.31.1: https://github.com/solana-foundation/anchor/releases/tag/v0.31.1

[smoelius]

Possibly relevant: solana-foundation/anchor#3663 (review)

[alrightCha]

no way of using 0.31.0 ? 0.31.1 doesn't seem to have poseidon

[smoelius]

Sorry, @alrightCha. This project is on pause right now.

It worked with 0.30.1 until the recent proc-macro2 change.

It has never worked with 0.31.x because of CLI incompatibilities between 0.30.1 and 0.31.x.

I assure you this is on my todo list; it's just not done yet.

[smoelius]

@alrightCha I'm going to close this issue as fixed by #23. I haven't made a release with that fix, because I am trying to resolve #5. But if you are willing to install from master, you should have something workable:

cargo install anchor-coverage --git https://github.com/trailofbits/anchor-coverage

If you have any comments or questions, you are welcome to drop them here or in another issue.

Thank you very much for your interest.

[Perelyn-sama]

cargo install anchor-coverage --git https://github.com/trailofbits/anchor-coverage

thanks for this @smoelius

I'm running anchor-coverage and I'm getting solana-test-validator is not patched. I ran all the previous commands so I'm unsure why

[smoelius]

I ran all the previous commands

Meaning you ran these?

anchor-coverage/README.md

Lines 16 to 18 in b30c8fd

	sed -i '/^\[patch\.crates-io\]$/a solana-sbpf = { git = "https://github.com/trail-of-forks/sbpf-coverage" }' Cargo.toml
	./scripts/cargo-install-all.sh .
	export PATH=$PWD/bin:$PATH

Could it be that you have a different solana-test-validator in your PATH?

Do you see sbf_trace_dir directories created? What are their contents?

[Perelyn-sama]

Meaning you ran these?

yes

Could it be that you have a different solana-test-validator in your PATH?

possibly, I already had agave installed before now

Do you see sbf_trace_dir directories created? What are their contents?

its empty

[smoelius]

Did you see a message like "patch was not used in the crate graph"?

If you are willing to try again, please check out commit 86faa211d988143483adbe4c0cf16bb5e5798582 in the Agave repository and build from there.

That is the commit that we test with in CI (more recent commits cause problems):

anchor-coverage/.github/workflows/ci.yml

Line 80 in b30c8fd

git checkout 86faa211d988143483adbe4c0cf16bb5e5798582

So the commands you should execute are:

git checkout 86faa211d988143483adbe4c0cf16bb5e5798582
sed -i '/^\[patch\.crates-io\]$/a solana-sbpf = { git = "https://github.com/trail-of-forks/sbpf-coverage" }' Cargo.toml
./scripts/cargo-install-all.sh . 
export PATH=$PWD/bin:$PATH

Apologies if this works, and your time was wasted by poor instructions.