Skip to content

Coverage reporting fixes #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 28, 2022
Merged

Coverage reporting fixes #121

merged 1 commit into from
Dec 28, 2022

Conversation

@nedbat
Copy link
Contributor

@nedbat nedbat commented Dec 28, 2022

  1. You need the [toml] extra to read .toml files before Python 3.11
  2. When you moved settings from setup.cfg to pyproject.toml, you left behind some of your path mappings.

I also fixed a bug in coverage.py what should have raised an error for having a .toml file without the [toml] extra.

@nedbat nedbat mentioned this pull request Dec 28, 2022
Closed
@gaborbernat gaborbernat merged commit 5d16771 into tox-dev:main Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaborbernat gaborbernat gaborbernat approved these changes

@ofek ofek Awaiting requested review from ofek ofek is a code owner

@Julian Julian Awaiting requested review from Julian

@RonnyPfannschmidt RonnyPfannschmidt Awaiting requested review from RonnyPfannschmidt

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nedbat @gaborbernat