Skip to content

Conversation

@toshimaru
Copy link
Owner

@toshimaru toshimaru commented Jan 23, 2023

  • Require Ruby 2.7 or more
  • Require Jekyll 3.9 or more
  • Sync test helper with upstream
  • Introduce appraisal and build CI matrix

```
# Running:

  Dependency Error: Yikes! It looks like you don't have kramdown-parser-gfm or one of its dependencies installed. In order to use Jekyll as currently configured, you'll need to install this gem. The full error message from Ruby is: 'cannot load such file -- kramdown-parser-gfm' If you run into trouble, you can find helpful resources at https://jekyllrb.com/help/!

Finished in 0.080125s, 37.4414 runs/s, 0.0000 assertions/s.
```
Test against jekyll-4.0 fails:

```
  3) Error:
Jekyll::Tags::IncludeSassTagTest#test_read_variable:
TypeError: no implicit conversion of Hash into Integer
```
@toshimaru toshimaru changed the title Require Ruby 2.7+ and Jekyll 3.9+ Require Ruby 2.7+ and Jekyll 3.9+ / Build CI matrix Jan 24, 2023
@toshimaru toshimaru marked this pull request as ready for review January 24, 2023 19:38
@toshimaru toshimaru merged commit 5b034b4 into main Jan 24, 2023
@toshimaru toshimaru deleted the drop-old-ruby branch January 24, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants