Skip to content

Potential Vulnerability: Missing Null-Termination in ecryptfs_fill_auth_tok #1259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Potential Vulnerability: Missing Null-Termination in ecryptfs_fill_auth_tok #1259

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7a27b1
keys: ecryptfs: null-terminate password signature
DiamondGotCat Jun 6, 2025
314d9b3
Merge pull request #1 from DiamondGotCat/codex/update-ecryptfs_fill_a…
DiamondGotCat Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions security/keys/encrypted-keys/ecryptfs_format.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ int ecryptfs_fill_auth_tok(struct ecryptfs_auth_tok *auth_tok,
auth_tok->token_type = ECRYPTFS_PASSWORD;
strncpy((char *)auth_tok->token.password.signature, key_desc,
ECRYPTFS_PASSWORD_SIG_SIZE);
/* Ensure signature string is null terminated as strncpy may not */
auth_tok->token.password.signature[ECRYPTFS_PASSWORD_SIG_SIZE] = '\0';
auth_tok->token.password.session_key_encryption_key_bytes =
ECRYPTFS_MAX_KEY_BYTES;
/*
Expand Down