Crypto: Ephemeral Instance Random Seeds with Keepers #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
da2ce7
force-pushed
the
crypto-static-keys
branch
from
5257e7e to
a898b18
Compare
Contributor
Author
|
Rebased after merge of #81 |
josecelano
requested changes
Sep 20, 2022
Member
josecelano
left a comment
josecelano
left a comment
There was a problem hiding this comment.
hi @da2ce7, I reviewed this PR and made some comments.
da2ce7
force-pushed
the
crypto-static-keys
branch
2 times, most recently
from
8051173 to
e5f1c38
Compare
da2ce7
changed the title
da2ce7
force-pushed
the
crypto-static-keys
branch
from
e5f1c38 to
d09c58f
Compare
Contributor
Author
|
ACK d09c58f |
da2ce7
force-pushed
the
crypto-static-keys
branch
from
d09c58f to
873293a
Compare
* Implement a lazy static that holds ephemeral seeds that are freshly generated on app load. * New `crypto` supporting module that provides a simple interface to accessing the seed. * Provide a 'default seed', that is zeroed-out when testing, and random when not testing.
Contributor
Author
|
ACK 873293a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module makes use of lazy_static, to initialize an instance ephemeral random seed for the server to use on startup.
This seed can be used to derive other instance ephemeral keys. The seed is forgotten upon shutdown of the server.
To help with testing, a
DefaultSeedhelping structure that provides a zeroed seed when testing, and the random seed when not testing.