Skip to content

Crate docs for servers::upd module #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2023
Merged

Crate docs for servers::upd module #273

merged 1 commit into from
Apr 10, 2023

Conversation

josecelano
Copy link
Member

Documentation for the crate::servers::udp module. The UDP tracker.

@josecelano josecelano linked an issue Apr 5, 2023 that may be closed by this pull request
crate docs: for servers::udp mod (UDP tracker) #271
Closed
@josecelano josecelano added the Documentation Improves Instructions, Guides, and Notices label Apr 5, 2023
da2ce7
da2ce7 reviewed Apr 5, 2023
View reviewed changes
da2ce7
da2ce7 reviewed Apr 5, 2023
View reviewed changes
Copy link
Contributor

@da2ce7 da2ce7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good. :)

@josecelano josecelano force-pushed the issue-271-crate-docs-for-udp-tracker-mod branch 6 times, most recently from 110bb04 to a5c9d2c Compare April 6, 2023 17:25
@josecelano josecelano force-pushed the issue-271-crate-docs-for-udp-tracker-mod branch from a5c9d2c to 7014a46 Compare April 6, 2023 17:33
@josecelano josecelano marked this pull request as ready for review April 6, 2023 17:34
@josecelano
Copy link
Member Author

Hi @da2ce7 @WarmBeer, this is ready to review. It would be nice if you reviewed the parts you implemented, like:

  • src/servers/udp/connection_cookie.rs
  • src/servers/apis/server.rs
  • src/servers/udp/server.rs
  • src/servers/http/server.rs

I'm going to continue documenting the packages as described here.

da2ce7
da2ce7 approved these changes Apr 7, 2023
View reviewed changes
Copy link
Contributor

@da2ce7 da2ce7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great! Really good work with the UDP Tracker documentation!

@josecelano
Copy link
Member Author

ACK 7014a46

@josecelano josecelano merged commit 046ca86 into torrust:develop Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@da2ce7 da2ce7 da2ce7 approved these changes

@mickvandijke mickvandijke Awaiting requested review from mickvandijke

Assignees
No one assigned
Labels
Documentation Improves Instructions, Guides, and Notices
Projects
Torrust Solution
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

crate docs: for servers::udp mod (UDP tracker)
2 participants
@josecelano @da2ce7