Axum HTTP tracker: add unit tests for custom Axum extractors #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not an Axum extractor. It's a wrapper of another custom Axum extractor which is used in handlers. Since it does not implements the trait `FromRequestParts` the `handlers` dir seems to be a better location.
|
Hi @da2ce7 @WarmBeer, this is ready to review. It's just some unit tests for the custom Axum extractors I've written in the new Axum HTTP tracker implementation. I plan to open some more PRs like this. I did not add too many unit tests to the Axum implementation because we had the integration tests and the design was still a proof of concept (since I'm a newbie with Axum and I did not know which solution would be the best). Besides, as I mentioned before, I prefer more unit tests and fewer integration tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.