Skip to content

Conversation

@josecelano
Copy link
Member

Remove default configuration values for secrets. To avoid running the tracker unintentionally with known values.

@josecelano josecelano added this to the v3.0.0 milestone Aug 12, 2024
@josecelano josecelano linked an issue Aug 12, 2024 that may be closed by this pull request
@josecelano josecelano self-assigned this Aug 12, 2024
@josecelano josecelano added Enhancement / Feature Request Something New - Admin - Enjoyable to Install and Setup our Software labels Aug 12, 2024
@josecelano
Copy link
Member Author

ACK 6a707b9

@codecov
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 35.29412% with 22 lines in your changes missing coverage. Please review.

Project coverage is 77.15%. Comparing base (eaa86a7) to head (6a707b9).

Files Patch % Lines
src/app.rs 0.00% 18 Missing ⚠️
src/console/ci/e2e/tracker_container.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1007      +/-   ##
===========================================
+ Coverage    77.10%   77.15%   +0.05%     
===========================================
  Files          185      185              
  Lines        10063    10068       +5     
===========================================
+ Hits          7759     7768       +9     
+ Misses        2304     2300       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josecelano
Copy link
Member Author

ACK 6a707b9

@josecelano josecelano merged commit f6bbcf5 into torrust:develop Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

- Admin - Enjoyable to Install and Setup our Software Enhancement / Feature Request Something New

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Config overhaul: make secrets mandatory

1 participant