Docker Support

[Zibbp]

Is Docker support planned? A docker container for the tracker and backend/frontend would be amazing.

https://blog.logrocket.com/packaging-a-rust-web-service-using-docker/

[PseudoResonance]

I built my own Docker image just to keep it more organized when running, but I ran into the issue that Torrust can't get the correct client IPs while inside Docker. There's a relevant issue here discussing the problem and some potential solutions, like giving the container host network access.
moby/moby#15086

[mickvandijke]

I'm planning on adding Docker images, after I add support for reverse proxy's 😄

[Zorlin]

I'll happily package this for Kubernetes once Docker support is done, as a bonus.

[josecelano]

I've created a PR with a Dockerfile only for this service. We could create docker images also for the backend and frontend. I think it would be also helpful to create a docker-compose file in order to build and run all the services with a single command. That it would make much easier to start coding and also it would make it easier for other developers to try things without having to install all the dependencies.

The docker-compose configuration could be located in a new repo. The other option could be generate docker-compose file only for the torrust-index. So when you start working you need to run two commands.

Right now developers are likely to work on all the projects at the same time but I suppose as the project became bigger you probably are not going to work on both the tracker and the index at the same time.

In conclusion, one docker-compose file for the torrust-index could be a good option and we can add it to the torrust-index repo.

[Zorlin]

Hi @josecelano - take a look at https://github.com/zorlin/torrust-docker ...

:)

[josecelano]

Hi @josecelano - take a look at https://github.com/zorlin/torrust-docker ...

:)

Hi @Zorlin cool!!!

Just a couple of questions/comments:

1. I think it would be nice to have a new docker layer for tracker and backend with only the dependencies as described here.
2. It seems your repo was designed to build a production release with the latest version of each repo. I was thinking more about using docker-compose for development. In that case I think it makes more sense to get the code from the context instead of with git clone.
3. I do not know why to put the binaries inside the docker image for Rust but you mount the node app in the caddy image ($PWD/data/frontend/dist/:/srv). Why do not you build the app in the Dockerfile?
4. It seems setup would be easier if the default config file is already included in the git repo instead of being generated on the fly by the app the first time is executed. We would get rid of some entry.sh scripts. But I suppose you followed the current installation steps. I think generating the default config file at runtime with default hardcoded values in the code instead of a default config file is an extra indirection level that may not be necessary, but I have not looked at the generation code, maybe there are some values that are calculated at runtime.
5. If we want to use docker for development, do you think would it make sense to move the Dokerfiles to their own repos? I have not used docker for Rust, since you have to compile after every change I do not know if it makes sense to use docker. Either you only used it as a virtual machine (you compile and start manually) or you can install a "watch" process to re-compile and restart the service every time you change a file. Does it make sense? If it does not make sense, then your approach of having an independent repo for docker config files is the best approach in my opinion.
6. Even if the tracker and backend have the same dependencies for production I think I would use two different docker images in the docker-compose file. It could be harder to split them later if you start adding dependencies that are only needed in one of the services.

I'm going to follow your instructions to run it on my laptop and I will give you feedback.

[Power2All]

@josecelano
If you want some tips about Docker deployment.
I already made one of my own separate project here, you could use that as well for your usage:

https://github.com/Power2All/torrust-axum/blob/master/docker/Dockerfile

Use it however you like though, it's suppose to be used in combination with either a direct host connection, or could be used in combination with Traefik/NGINX for instance.
Configuration is done through the init.sh which you can find there as well, which build the configuration file based on the ENVIRONMENT variables.

It's not perfect, but it works pretty good.

[josecelano]

Traefik/NGINX

Thank you, @Power2All I've been looking at it. I'm working on this PR.

I have defined some requirements on the PR. Feedback for the requirements is welcome. I have not added an explicit goal for the PR, but mainly I want to:

• Write the basic docker configuration for development and production that could be used to build your own deployments (wherever you want to deploy it, if you want to use docker).
• Try to find a very easy way to deploy the application. I'm testing Azure Container Instances because the docker console command has support for it, and I thought most developers are familiar with it.
• I think docker is the best way to write "live documentation" for your application's system dependencies.

I see you have also added SSL support for the API.

[Power2All]

Thank you, @Power2All I've been looking at it. I'm working on this #123.

No problem, been busy with a new job I just started at, so I've not been around much to work on the code lately anyhow. Good thing the project is still moving :)

I see you have also added SSL support for the API.

Correct, wasn't really that hard though.
Basically, just added the same thing as it was for the other sockets ;)