Fix tornado.web.RequestHandler.get_browser_locale() #3068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
spaceone
commented
Oct 1, 2021
spaceone
commented
- fix optional whitespace parsing of Accept-Language header
- fix ignoring quality=0 values in Accept-Language
- disallow negative quality values in Accept-Language
HTTP allows OWS between parameters: `Accept-Language: de-DE; q=0.1, en-US; q=0.2`
`Accept-Language: en-US; q=0, de-DE; q=0.5` means that english MUST not be selected.
`Accept-Language: en-US; q=-1` is not allowed. ignore it. Even better would be to raise HTTP 400 Bad Request.
Member
|
Thanks for the contribution! All of these changes look good, but they're the sort of thing that really should have a test (and it looks easy enough to write one). |
Contributor
Author
|
@bdarnell added the tests. |
Contributor
Author
|
@bdarnell anything else? |
Member
|
Looks good; thank you and I apologize for the lengthy delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.