add simple_httpclient connection pool support #1622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add connection pool support
fixed lambda param error.
Member
|
I'm very sorry to let this sit so long with no response. I haven't given this a detailed review since it needs updating to be mergeable, but I'm leaving it open for the next time someone tries to take a shot at this feature. One thing that's missing here that is absolutely necessary before anything like this is testing. We need tests that make sure that connections are reused when they can be and not when they shouldn't be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep-Alive pooling to SimpleAsyncHTTPClient per #1457 .