Add {UShort, UInt, ULong}Tensor #566
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
! DO NOT MERGE YET !
This PR adds support for three new unsigned Tensor types: UShortTensor, UIntTensor, ULongTensor.
I did a first quick pass over the torch project and added the new types at obvious places. I would be glad if developers who are more familiar with TH an torch could review the changes and let me know what is missing...
Resulting binary sizes
It can be seen that the binary size increases significantly.
Note: In order to generate files with cwrap for unsigned {short, int, long} I had to make a tiny modification to cwrap.
Example (similar to ByteTensor)