chore: using explicit types instead of literal types
#329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danil42Russia
changed the title
literal types
Danil42Russia
force-pushed
the
danil42russia/type
branch
from
39d174d to
556d766
Compare
Danil42Russia
commented
Sep 28, 2025
| version?: NetworkVersion; | ||
| key?: string; | ||
| type?: 'mainnet' | 'testnet' | 'custom'; | ||
| type?: Network; |
There was a problem hiding this comment.
i would rename the type Network to NetworkType because the name Network describes the finished structure more than the type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #
Checklist
Please ensure the following items are completed before requesting review:
CHANGELOG.mdwith relevant changesREADME.mdyarn test)yarn lint)