-
Notifications
You must be signed in to change notification settings - Fork 378
Update minimum value for ton forward #1451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| :::caution Transaction notification | ||
| Each service in the ecosystem is expected to set `forward_ton_amount` to 0.000000001 TON (1 nanoton) when withdrawing a token to send a jetton Notify on [successful transfer](https://testnet.tonviewer.com/transaction/a0eede398d554318326b6e13081c2441f8b9a814bf9704e2e2f44f24adb3d407), otherwise the transfer will not be compliant. It will not be able to be processed by other CEXs and services. | ||
| Each service in the ecosystem is expected to set `forward_ton_amount` to 0.001 TON when withdrawing a token to send a jetton Notify on [successful transfer](https://testnet.tonviewer.com/transaction/a0eede398d554318326b6e13081c2441f8b9a814bf9704e2e2f44f24adb3d407), otherwise the transfer will not be compliant. It will not be able to be processed by other CEXs and services. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about totally removing this sentence? It is misleading
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which one of the sentences do you mean? We need all CEX to send a notification message for precise event tracking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Shvandre could you take a look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally incomprehensible what services is meant to set fwdTonAmount. Any? Of course not, because setting ANY fwdTonAmount is compliant with TEP-74 standard.
when withdrawing a token
Withdrawing from where? Usually when you withdraw something means you will receive an asset on your wallet as the result. The fwdTonAmount makes nothing in this case, it can be set to any amount.
otherwise the transfer will not be compliant. It will not be able to be processed by other CEXs and services.
That is the pure lie. This transfer will be compliant with TEP-74. Moreover, it will be processed by most CEX-es.
Moreover, IIRC tonkeeper sets fwdTonAmount to 1 nanoton, when doing regular Jetton transfers from wallet. Does that mean it’s a poorly designed wallet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check comment above.
|
Outdated |
Description
PR Description:
Increasing
forward_ton_amountto 0.001 TON is required to improve deposit processing for Jetton, NFT, etc. Currently, sending 1 nanoton results in unnecessary storage fee deductions on the destination address, which may freeze the destination address if the balance is low and there's been no recent activity. Also as the notify message arrives with insufficient funds to execute TVM it is impossible to do processing with the contract which hurts DeXes for example. This change partially resolves both issues, ensuring reliable contract execution and preventing unnecessary address freezes.Checklist