Skip to content

Conversation

rM-self-serve
Copy link
Contributor

@rM-self-serve rM-self-serve commented Feb 6, 2023

Add package: webinterface-wifi

@Eeems Eeems added the packages Add or improve packages of the repository label Feb 8, 2023
Copy link
Member

@Eeems Eeems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. It would be good to add some sort of application to start/stop the service in the future. Right now users will have to use yaft to start/stop to temporarily use it.
Having a SSID whitelist would also be an option, that or putting a password in front of it so it can stay on all the time?

@Eeems Eeems merged commit 6bfe4d8 into toltec-dev:testing Feb 8, 2023
@rM-self-serve
Copy link
Contributor Author

Thanks again for the help! I definitely plan to add whitelist/blacklist functionality. Going to look into some existing packages for the best way to handle a config file and will add some command line options to configure it. I'm thinking of defaulting to a whitelist containing only the SSID of the wifi network that webinterface-wifi is installed/configured on. I would also prefer the application update the config rather than the service file when changing a port.

@Eeems
Copy link
Member

Eeems commented Feb 10, 2023

I really recommend following the XDG standards. Config files should either be in /opt/etc or ~/.config. It would probably be better to put it in /opt/etc since it's installed as a service that doesn't run for a specific user session, and it's meant to be modified by the user. I'd also recommend adding a small cli for modifying the settings live without having the restart the service.

Eeems added a commit that referenced this pull request Feb 28, 2023
* Add package: webinterface-wifi

---------

Co-authored-by: Nathaniel van Diepen <[email protected]>
Eeems added a commit that referenced this pull request Mar 7, 2023
* Update KOReader to v2022.11 (#659)

* Update oxide to v2.5 (#662)

Update the following applications to 2.5:
- erode
- fret
- oxide
- rot
- tarnish
- decay
- corrupt
- anxiety
- liboxide
Update libsentry to 0.5.0
Add new notify-send package

* Add package: webinterface-wifi (#664)

* Add package: webinterface-wifi

---------

Co-authored-by: Nathaniel van Diepen <[email protected]>

* Add package: neofetch (#665)

* Update KOReader to v2023.01 (#663)

* Update display and rm2fb-client to v0.0.29 (#656)

* Update display and rm2fb-client to v0.0.28

Fixes bug with Remarkable desktop app screen share freezing (ddvk/remarkable2-framebuffer#71)

* Update rm2fb to v0.0.29

---------

Co-authored-by: Nathaniel van Diepen <[email protected]>

* Update rm2fb to v0.0.30 (#666)

Fix crash due to invalid notify address for 3.0.4.1305.

---------

Co-authored-by: rM-self-serve <[email protected]>
Co-authored-by: Neil Innes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages Add or improve packages of the repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants