-
Notifications
You must be signed in to change notification settings - Fork 70
templatectl: Add/Remove items from templates.json via cli #222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
templatectl: Add/Remove items from templates.json via cli #222
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works like a charm 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR @PeterGrace! Here are a few comments.
Co-authored-by: Mattéo Delabre <[email protected]>
Co-authored-by: Mattéo Delabre <[email protected]>
Co-authored-by: Mattéo Delabre <[email protected]>
Co-authored-by: Mattéo Delabre <[email protected]>
Co-authored-by: Mattéo Delabre <[email protected]>
Co-authored-by: Mattéo Delabre <[email protected]>
Co-authored-by: Mattéo Delabre <[email protected]>
Co-authored-by: Mattéo Delabre <[email protected]>
Co-authored-by: Mattéo Delabre <[email protected]>
Co-authored-by: Mattéo Delabre <[email protected]>
Co-authored-by: Mattéo Delabre <[email protected]>
|
Deferring system upgrade question until we handle #109 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matteodelabre I think this is ready to merge, but I'd like you to double check my changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Going to test this on my device and will report back with comments. Here are some notes on the diff:
Co-authored-by: Mattéo Delabre <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on rM1, works great! As might be expected, I had to restart xochitl to make the templates appear, this might confuse users as it’s not explicitly mentioned in the install output.
Perhaps that's something templatectl should be in charge of outputting if it detects that xochitl is runing? |
(Re-open of PR #221 with proper branch targeting.)
This PR adds a package file for templatectl, which is a rust-based binary that interacts with the
/usr/share/remarkable/templates/templates.jsonfile. It can add entries and remove entries from the file, sparing the end user the need to edit the json file manually.Additionally, since it is a cli-based app and will be installable via toltec, we can then use it to package template files in toltec for installing to xochitl from the package repository.