Skip to content

Conversation

@PeterGrace
Copy link

(Re-open of PR #221 with proper branch targeting.)

This PR adds a package file for templatectl, which is a rust-based binary that interacts with the /usr/share/remarkable/templates/templates.json file. It can add entries and remove entries from the file, sparing the end user the need to edit the json file manually.

Additionally, since it is a cli-based app and will be installable via toltec, we can then use it to package template files in toltec for installing to xochitl from the package repository.

LinusCDE
LinusCDE previously approved these changes Jan 14, 2021
Copy link
Member

@LinusCDE LinusCDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works like a charm 👍

@LinusCDE LinusCDE requested a review from Eeems January 14, 2021 02:42
Eeems
Eeems previously requested changes Jan 14, 2021
Copy link
Member

@matteodelabre matteodelabre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR @PeterGrace! Here are a few comments.

@matteodelabre matteodelabre added tooling Set of scripts and configuration files for building the packages packages Add or improve packages of the repository and removed tooling Set of scripts and configuration files for building the packages labels Jan 14, 2021
@matteodelabre matteodelabre mentioned this pull request Jan 14, 2021
28 tasks
@Eeems
Copy link
Member

Eeems commented Jan 17, 2021

Deferring system upgrade question until we handle #109

@Eeems Eeems self-requested a review January 17, 2021 02:57
Copy link
Member

@Eeems Eeems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matteodelabre I think this is ready to merge, but I'd like you to double check my changes.

@Eeems Eeems dismissed their stale review January 17, 2021 02:58

Changes done.

Copy link
Member

@matteodelabre matteodelabre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Going to test this on my device and will report back with comments. Here are some notes on the diff:

matteodelabre
matteodelabre previously approved these changes Jan 17, 2021
Copy link
Member

@matteodelabre matteodelabre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on rM1, works great! As might be expected, I had to restart xochitl to make the templates appear, this might confuse users as it’s not explicitly mentioned in the install output.

@Eeems
Copy link
Member

Eeems commented Jan 17, 2021

Tested on rM1, works great! As might be expected, I had to restart xochitl to make the templates appear, this might confuse users as it’s not explicitly mentioned in the install output.

Perhaps that's something templatectl should be in charge of outputting if it detects that xochitl is runing?

@Eeems Eeems merged commit 5f1e89f into toltec-dev:testing Jan 17, 2021
@PeterGrace PeterGrace deleted the peter.grace/add-templatectl-to-testing branch January 17, 2021 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages Add or improve packages of the repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants