tracing-subscriber: count numbers of enters in Timings
#2944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkw
approved these changes
May 3, 2024
joshka
added a commit
to joshka/tracing
that referenced
this pull request
Jul 23, 2024
This commit refactors the `Timings` struct to use `Duration` instead of `u64` to store the idle and busy times of a span, and moves the logic to update the timings to the `Timings` struct itself. This commit also introduces a `display` method to the `Timings` struct that returns the idle and busy times as `HumanReadableDuration` instances (renamed from `TimingDisplay`). Replaces: tokio-rs#2944
joshka
added a commit
to joshka/tracing
that referenced
this pull request
Jul 23, 2024
This commit refactors the `Timings` struct to use `Duration` instead of `u64` to store the idle and busy times of a span, and moves the logic to update the timings to the `Timings` struct itself. This commit also introduces a `display` method to the `Timings` struct that returns the idle and busy times as `HumanReadableDuration` instances (renamed from `TimingDisplay`). Replaces: tokio-rs#2944
9 tasks
hds
pushed a commit
that referenced
this pull request
Jun 6, 2025
hds
pushed a commit
that referenced
this pull request
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The timings measurements were done naively in a way where they added
busytime inon_exitandidletime in `on_enter. This works only if the spans are not entered multiple times. For example if a span is:The timing would be about 1 second of idle time and no busy time.
Solution
Count the relative number of enters and exits and only increment the timers on top-level enters and exits.