Skip to content

time: use bit manipulation instead of modulo #4480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 15, 2022
Merged

time: use bit manipulation instead of modulo #4480

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
561a665
time: use bit manipulation instead of modulo
samueltardieu Feb 8, 2022
bc4059b
time: add comment to explain the bit manipulation
samueltardieu Feb 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tokio/src/time/driver/wheel/level.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,9 @@ impl Level {
let level_range = level_range(self.level);
let slot_range = slot_range(self.level);

// TODO: This can probably be simplified w/ power of 2 math
let level_start = now - (now % level_range);
// Compute the start date of the current level by masking the low bits
// of `now` (`level_range` is a power of 2).
let level_start = now & !(level_range - 1);
let mut deadline = level_start + slot as u64 * slot_range;

if deadline <= now {
Expand Down