Skip to content

Conversation

@Darksonn
Copy link
Contributor

@Darksonn Darksonn commented Oct 1, 2023

This performs various cleanup:

  • Factor a lot of panics into functions to improve error messages and reduce codegen.
  • Add missing #[inline] and #[track_caller].
  • Fix some arithmetic overflows in bounds checks.

Copy link

@hds hds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. The unsafe section explanations all appear correct. Although I'm not very familiar with this code base, so you might want someone else to have a look too.

@Darksonn Darksonn merged commit fd9243f into master Oct 2, 2023
@Darksonn Darksonn deleted the alice/patch-01 branch October 2, 2023 13:40
@braddunbar braddunbar mentioned this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants