Skip to content

Conversation

@taiki-e
Copy link
Member

@taiki-e taiki-e commented May 23, 2020

No description provided.

@taiki-e taiki-e force-pushed the github-actions branch 3 times, most recently from 517fed2 to fee3614 Compare May 23, 2020 23:52
@taiki-e
Copy link
Member Author

taiki-e commented May 24, 2020

Ok, loom test failure will be fixed by Xudong-Huang/generator-rs#20, and everything else passed.

Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@taiki-e
Copy link
Member Author

taiki-e commented May 24, 2020

Hmm..., it seems that we need to change the "required statuses" of the branch protection settings to merge this (requires admin rights).

@seanmonstar Could you change the branch protection settings? (I guess you have admin rights)

@seanmonstar
Copy link
Member

@taiki-e I think they're all set (the list has a lot of old options to require).

@taiki-e
Copy link
Member Author

taiki-e commented May 24, 2020

@seanmonstar Thanks! I confirmed they are set. I'm going to merge this...

@taiki-e taiki-e merged commit 64fe7e1 into master May 24, 2020
@taiki-e taiki-e deleted the github-actions branch May 24, 2020 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants