Eject key missing from HHKB layout

[marcaddeo]

Just installed the alt controller, which I assume is just flashed with the default hhkb layout but it seems to be missing the Eject key (Fn + f)

[tmk]

I don't know how it works and if it is useful.

Anyway I don't mind adding that key, feel free to send a pull request. Please test it on windows and Mac if possible.

[marcaddeo]

On OS X you can use Shift + Ctrl + Eject to lock your screen, so I find it useful :)

I will have to look around the repository and learn more before I can submit a pull request. Will take a look though.

[marcaddeo]

Hmm, after toying around with this for a little while I'm having trouble finding the keycode for eject. I think OS X intercepts it before Karabiner's EventListener can read it... Or something... Not really sure, because even just hitting Fn + f (as well as holding it down for a while) on the original HHKB controller nothing shows up in EventListener.

Do you have a linux box you could run xev on with the original HHKB controller to see what hitting Fn + f sends to the machine? Not sure if this is even a reasonable solution to finding the keycode....

[tmk]

I got this on xev. I'm not sure what Eject key on HHKB spits out but I'm sure KC_EJCT( KC_MEDIA_EJECT) is not it.

KeyPress event, serial 38, synthetic NO, window 0x8000001,
    root 0x246, subw 0x0, time 1632092085, (-496,231), root:(215,763),
    state 0x10, keycode 198 (keysym 0x1008ffb2, XF86AudioMicMute), same_screen YES,
    XLookupString gives 0 bytes: 
    XmbLookupString gives 0 bytes: 
    XFilterEvent returns: False

KeyRelease event, serial 38, synthetic NO, window 0x8000001,
    root 0x246, subw 0x0, time 1632092197, (-496,231), root:(215,763),
    state 0x10, keycode 198 (keysym 0x1008ffb2, XF86AudioMicMute), same_screen YES,
    XLookupString gives 0 bytes: 
    XFilterEvent returns: False

[tmk]

OK. I used my USB-USB converter to look into the keycode, it is 0x6F, namely F20. Try it.

[marcaddeo]

Awesome! Now I just need to learn how to load a new firmware without screwing everything up! :) That shall be tonights project!

[tmk]

I added document of HHKB original keycodes.
https://github.com/tmk/tmk_keyboard/blob/master/keyboard/hhkb/doc/HHKB_keycodes.txt#L22

And FAQ.
https://github.com/tmk/tmk_keyboard/wiki/FAQ-Keymap#eject-on-mac-osx

[marcaddeo]

@tmk so has this been added to the hhkb layout? Or did you just document it? My battery just came for my BT controller yesterday so I was gonna try and figure this out this weekend.

I didn't see any code changes in the commits, only the documentation. So I assume I still need to create a PR for this.

As for adding the eject key, do I just need to update keymap_hhkb.c and change TRNS after the MUTE in layer 1 to be EJECT? Or does the EJECT key first need to be defined somewhere as 0x6F? OR, and more likely, do I just put F20 there?

[persocon]

Bro, having the same issue, tried to add F20 and nothing happened :/
also couldn't modify this: https://github.com/tmk/tmk_keyboard/wiki/FAQ-Keymap#apple-keyboard-fn
to work the fn key properly :/

[tmk]

I'm sure about original HHKB controller spitting out F20 for Fn+F(eject).
Does Fn+F on original HHKB works?

If you understand this correctly and know HID spec you can implements Apple Fn on HHKB hopefully.

[persocon]

Isn't a matter of just changing the hex? I thought was and didn't worked haha I may be stupid tho.
I just heard about the Fn+F on other places too, I read on some HID spec that F20 is 0x5F and not 0x6F know, and reading your part of the code where the 0x5F is I thought well better not change anything or I will explode this and burn another chip

[marcaddeo]

@persocon I was able to get it working by setting the TRNS after the MUTE key to be EJCT.

I'm pretty sure that isn't exactly the same as the default HHKB Fn + f, but it seems to be working for me.

[persocon]

@marcaddeo and the default Fn key from mac you were able to make work too? will try that Mute to Ejct