Skip to content
This repository was archived by the owner on Jun 8, 2023. It is now read-only.

Conversation

@karolis-sh
Copy link
Contributor

@karolis-sh karolis-sh commented Jun 6, 2019

fix #102

I think I fixed the monorepo cases just the way they worked in babel 6.

EDIT: Though now that I think about it I'm not sure if this is the desired approach. This fixes the breaking change (for some users), but previous lookup by package.json seems more predictable as usually you babelify from child package not the root one. And there's the cwd option how that should work in monorepo 🧐

@codecov
Copy link

codecov bot commented Jun 6, 2019

Codecov Report

Merging #104 into master will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted Files Coverage Δ
src/index.js 94.54% <100%> (+0.1%) ⬆️

1 similar comment
@codecov
Copy link

codecov bot commented Jun 6, 2019

Codecov Report

Merging #104 into master will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted Files Coverage Δ
src/index.js 94.54% <100%> (+0.1%) ⬆️

Copy link
Owner

@tleunen tleunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for digging into the issue and sending a PR.
Could you check if we could use the exposed functions from babel to know where the config is instead of relying on another package?

"import"
],
"dependencies": {
"find-babel-config": "^1.2.0",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funny how I was thinking to deprecate the library as there should be a better "official" way of fetching the config now (see babel/babel#7472)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Possible regression with v5.1.0

2 participants