Create new command with class constructor #1339
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadowspawn
added
the
semver: major
Collaborator
|
After some more thinking, perhaps not. This works nicely if the subclass keeps the same signature for the constructor, which will usually be the case. However, the subclass may ignore the name or require additional parameters in its constructor. Expecting the subclass to define createCommand is simplistic, but means the calling convention for creating subcommand is explicit. A single parameter which is the command name. The subclass can do what wants for its constructor. |
Collaborator
|
Also, the return type of |
Contributor
Author
|
agree, subclass can overide this method, if needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.