Skip to content

Excess whitespace removal throughout a string #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 20, 2017
Merged

Excess whitespace removal throughout a string #197

merged 3 commits into from
Nov 20, 2017

Conversation

@stephlocke
Copy link
Contributor

Function uses str_replace() and stri_trim_both() to remove excess spaces.

@stephlocke
Copy link
Contributor Author

@hadley - new PR with requested stuff from #177

@stephlocke stephlocke changed the title str_squish (per #177) to enable excess whitespace removal throughout a string Excess whitespace removal throughout a string Nov 19, 2017
hadley
hadley reviewed Nov 20, 2017
View reviewed changes
NEWS.md Outdated
`str_replace()` and `str_replace_all()` to remove patterns from strings.
(@Shians, #178)

* `str_squish()` removes excess spaces from both the left and right side of strings. (@stephlocke #197)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the middle?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot

Added: b171a5e

@hadley hadley merged commit 17515f2 into tidyverse:master Nov 20, 2017
@hadley
Copy link
Member

hadley commented Nov 20, 2017

Thanks!

hadley added a commit that referenced this pull request Nov 20, 2017
@hadley
Tweaks for #197
f9402d2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hadley hadley hadley left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stephlocke @hadley