Skip to content

Conversation

teunbrand
Copy link
Collaborator

This PR aims to fix a problem identified in #6469.

Briefly, some packages assumed that facet$params$labeller is a function.
In #6138 we stopped matching character input to functions, so that no longer holds true.
This PR matches character input to functions again.

@teunbrand teunbrand added this to the ggplot2 4.0.0 milestone May 22, 2025
Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teunbrand teunbrand merged commit 68ab7bf into tidyverse:main May 23, 2025
13 checks passed
@teunbrand teunbrand deleted the revdep_labeller branch May 23, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants